Quantcast

[supercollider/supercollider] 363fda: class lib: remove comment in Poll.sc

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[supercollider/supercollider] 363fda: class lib: remove comment in Poll.sc

GitHub
  Branch: refs/heads/master
  Home:   https://github.com/supercollider/supercollider
  Commit: 363fdae6eecb1edec3644fac880f0e8ac476473b
      https://github.com/supercollider/supercollider/commit/363fdae6eecb1edec3644fac880f0e8ac476473b
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Audio/Poll.sc

  Log Message:
  -----------
  class lib: remove comment in Poll.sc


  Commit: 5a261b3d90f43334ec2f03db4ea0e965867347ed
      https://github.com/supercollider/supercollider/commit/5a261b3d90f43334ec2f03db4ea0e965867347ed
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Control/Buffer.sc

  Log Message:
  -----------
  class lib: refactor Buffer:get/n to use OSCFunc

This commit replaces the now-discouraged OSCpathResponder class with OSCFunc in the methods Buffer:get and Buffer:getn. It also adds some explanatory comments for those of us who haven't memorized the server OSC API.


  Commit: afacca942e7242761998b37e4bbaf1fa897170a6
      https://github.com/supercollider/supercollider/commit/afacca942e7242761998b37e4bbaf1fa897170a6
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Control/Bus.sc

  Log Message:
  -----------
  class lib: refactor Bus:get/n to use OSCFunc

This commit replaces the now-deprecated OSCpathResponder with OSCFunc in the methods Bus:get and Bus:getn.


  Commit: c0cb6c70c4345b078701565b3b249e843ed18228
      https://github.com/supercollider/supercollider/commit/c0cb6c70c4345b078701565b3b249e843ed18228
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Control/Node.sc

  Log Message:
  -----------
  class lib: refactor Node:get/n to use OSCFunc

This commit refactors Node:get and Node:getn to use OSCFunc instead of the now-discouraged class OSCpathResponder. It also adds some comments to explain the magic number indexes.


  Commit: 99f592ecc4c153fc72c6db789174f5b1de12d9ca
      https://github.com/supercollider/supercollider/commit/99f592ecc4c153fc72c6db789174f5b1de12d9ca
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M testsuite/classlibrary/TestBuffer.sc
    M testsuite/classlibrary/TestBus.sc
    A testsuite/classlibrary/TestNode.sc

  Log Message:
  -----------
  class lib: add unit tests for Buffer/Bus/Node:get/n

This commit adds unit tests for six methods that were recently refactored:

- Buffer:get
- Buffer:getn
- Bus:get
- Bus:getn
- Node:get
- Node:getn


  Commit: 8795c5dca599c6a7c8301d6f13ad2b9538d2de70
      https://github.com/supercollider/supercollider/commit/8795c5dca599c6a7c8301d6f13ad2b9538d2de70
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M testsuite/classlibrary/TestNode.sc

  Log Message:
  -----------
  TestNode: tabs, not spaces


  Commit: 1f3c048c84ea2b003027549a603e90a2347bc3f4
      https://github.com/supercollider/supercollider/commit/1f3c048c84ea2b003027549a603e90a2347bc3f4
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M testsuite/classlibrary/TestBuffer.sc
    M testsuite/classlibrary/TestCoreUGens.sc
    M testsuite/classlibrary/TestEvent.sc

  Log Message:
  -----------
  class lib: OSCresponderNode => OSCFunc in some unit tests

This commit refactors tests in TestBuffer and TestCoreUGens to use OSCFunc instead of OSCresponderNode. It also removes an extraneous comment in TestEvent.


  Commit: c46f7a38007b13868cc4e957b0d985d9dfde2881
      https://github.com/supercollider/supercollider/commit/c46f7a38007b13868cc4e957b0d985d9dfde2881
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Control/Node.sc

  Log Message:
  -----------
  class lib: Node: fix typo


  Commit: 54c20ca6bd9583e3a56dbf2dd549fa93751a9d47
      https://github.com/supercollider/supercollider/commit/54c20ca6bd9583e3a56dbf2dd549fa93751a9d47
  Author: Nathan Ho <[hidden email]>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M SCClassLibrary/Common/Control/Buffer.sc
    M SCClassLibrary/Common/Control/Bus.sc

  Log Message:
  -----------
  class lib: Buffer & Bus: strings->symbols, reduce dupe code

This commit minorly refactors some code in Buffer and Bus. OSC message strings like "/n_set" have been changed to symbols, e.g. \n_set.


  Commit: 4607b7ae324d5e6b29dde6a8d95a8094006e1a71
      https://github.com/supercollider/supercollider/commit/4607b7ae324d5e6b29dde6a8d95a8094006e1a71
  Author: Brian Heim <[hidden email]>
  Date:   2017-03-03 (Fri, 03 Mar 2017)

  Changed paths:
    M SCClassLibrary/Common/Audio/Poll.sc
    M SCClassLibrary/Common/Control/Buffer.sc
    M SCClassLibrary/Common/Control/Bus.sc
    M SCClassLibrary/Common/Control/Node.sc
    M testsuite/classlibrary/TestBuffer.sc
    M testsuite/classlibrary/TestBus.sc
    M testsuite/classlibrary/TestCoreUGens.sc
    M testsuite/classlibrary/TestEvent.sc
    A testsuite/classlibrary/TestNode.sc

  Log Message:
  -----------
  Merge pull request #2746 from snappizz/topic/stop-using-oscresponder

class lib: stop using OSCpathResponder


Compare: https://github.com/supercollider/supercollider/compare/8b1b64ed8e6b...4607b7ae324d
Loading...