Quantcast

[supercollider/supercollider] a89957: Make primitive exception handling per-PyrThread

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[supercollider/supercollider] a89957: Make primitive exception handling per-PyrThread

noreply
  Branch: refs/heads/fix-primitive-exception-handling
  Home:   https://github.com/supercollider/supercollider
  Commit: a899571599fc20e8131ae62bb72f6af25106d7ae
      https://github.com/supercollider/supercollider/commit/a899571599fc20e8131ae62bb72f6af25106d7ae
  Author: Scott Wilson <[hidden email]>
  Date:   2017-05-16 (Tue, 16 May 2017)

  Changed paths:
    M lang/LangPrimSource/PyrPrimitive.cpp
    M lang/LangSource/VMGlobals.h

  Log Message:
  -----------
  Make primitive exception handling per-PyrThread

- We cannot store exception info directly in the PyrThread, as PyrThreads are never constructed in the normal C++ sense (made in the GC pool), so we store it instead in a map in the VMGlobals instance, using the thread as a key.
- this makes it both per-thread, and supports any future implementations using multiple VMs.


  Commit: 0a90dcab783cd43cb8e2bf5e970865d2560a1734
      https://github.com/supercollider/supercollider/commit/0a90dcab783cd43cb8e2bf5e970865d2560a1734
  Author: Scott Wilson <[hidden email]>
  Date:   2017-05-16 (Tue, 16 May 2017)

  Changed paths:
    M lang/LangPrimSource/PyrPrimitive.cpp

  Log Message:
  -----------
  Use std::string for primitive error string

Signed-off-by: Scott Wilson <[hidden email]>


Compare: https://github.com/supercollider/supercollider/compare/d418a48c2be0...0a90dcab783c
Loading...